Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Gentoo + python 3.x #15

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

dizzy2
Copy link

@dizzy2 dizzy2 commented Sep 18, 2017

added support for gentoo linux
fixed few issues comming from python 3x

istvanp and others added 5 commits August 25, 2017 20:38
In some cases there are extraneous spaces in the configuration file for visual aid (or simply accidental) preventing the domains from being picked up. Also adding `req.ssl_sni` as a valid criterion for non-http TLS traffic.
Allow whitespaces in domain ACL regex
@martijn
Copy link

martijn commented Nov 2, 2017

The CLI_DEFAULTS_GENTOO_BASED_SYSTEMD_OS refers to /sbin/service which seems contradictory for a systemd operating system. Does Gentoo have an init-system agnostic service tool? In that case the 'systemd' part should be left out of the constant name.

@dizzy2
Copy link
Author

dizzy2 commented Nov 2, 2017

Yes, I forgot - You are right. Gentoo has support for more init systems (https://wiki.gentoo.org/wiki/Comparison_of_init_systems) and my solution works only for openRC. Maybe we can rename the whole branch to something like gentoo_openrc, but that makes the detection code more complicated...
But back to Your question - I am not sure if gentoo has a universal service tool and I think it would be slightly complicated to support (and maintain) all init systems supported by gentoo. So I would suggest to add a big note into documentation (and maybe a comment in source code), that only openRC on gentoo is actually supported and people are welcome to provide definitions for other init systems...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants